From eb01e08b041e8d89d4ca155680c63ce140fd0545 Mon Sep 17 00:00:00 2001 From: Chris Howell Date: Thu, 8 Oct 2020 13:36:33 -0700 Subject: [PATCH 1/2] Add explicit utf-8 encoding for file I/O in test_api.py --- youtube_transcript_api/test/test_api.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/youtube_transcript_api/test/test_api.py b/youtube_transcript_api/test/test_api.py index a081711..7618c9a 100644 --- a/youtube_transcript_api/test/test_api.py +++ b/youtube_transcript_api/test/test_api.py @@ -21,7 +21,10 @@ from youtube_transcript_api import ( def load_asset(filename): - with open('{dirname}/assets/{filename}'.format(dirname=os.path.dirname(__file__), filename=filename)) as file: + filepath = '{dirname}/assets/{filename}'.format( + dirname=os.path.dirname(__file__), filename=filename) + + with open(filepath, encoding='utf-8') as file: return file.read() From 150c50cabea589263daf877470105f762bf482ec Mon Sep 17 00:00:00 2001 From: Chris Howell Date: Thu, 8 Oct 2020 14:29:26 -0700 Subject: [PATCH 2/2] Fix since Python2.7 doesnt support encoding kwarg to open() --- youtube_transcript_api/test/test_api.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/youtube_transcript_api/test/test_api.py b/youtube_transcript_api/test/test_api.py index 7618c9a..5f95451 100644 --- a/youtube_transcript_api/test/test_api.py +++ b/youtube_transcript_api/test/test_api.py @@ -24,8 +24,8 @@ def load_asset(filename): filepath = '{dirname}/assets/{filename}'.format( dirname=os.path.dirname(__file__), filename=filename) - with open(filepath, encoding='utf-8') as file: - return file.read() + with open(filepath, mode="rb") as file: + return file.read().decode('utf-8') class TestYouTubeTranscriptApi(TestCase):